Jagadish Krishnamoorthy

ERC4626 Tracker should be part of release

2

As per the discussion https://forum.openzeppelin.com/t/erc4626-vault-implementation-for-totalassets-in-base-contract/29474 and https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3497#issuecomment-1162864795 , requesting "ERC4626 Tracker" contract as part of release. cc @Amxx

Would it be better to transfer the _stake amount to contract address itself instead of burn in createStake() ? https://github.com/HQ20/StakingToken/blob/master/contracts/StakingToken.sol#L50 _burn subtracts the totalSupply and hence the suggestion. Similarly for...

1. Call dutchAuctionPrice() to get the price in dutchAuctionMint() 2. Add revert logic for "if dutch auction has not started yet" in dutchAuctionPrice() 3. Add named return param in dutchAuctionPrice()...

[ROCm] Fix distributed tests failure

2

Distributed tests fails due to AttributeError: 'torch._C._distributed_c10d.ProcessGroup' object has no attribute '_set_backend' , when running distributed/test_c10d_spawn_gloo.py This leads to tests not progressing resulting in hang. Check if the attribute '_set_backend'...

Implement _isApprovedOrOwner()

3

## Description Implements https://github.com/Rari-Capital/solmate/issues/288 ## Checklist Ensure you completed **all of the steps** below before submitting your pull request: - [x] Ran `forge snapshot`? - [x] Ran `npm run lint`?...

EC721: Add isApprovedorOwner() support

3

isApprovedorOwner() is useful function which verifies given address is owner or approved for a nft. Any reason why this function is not included ?

## Description Any unwanted donation to vault should not be tracked. Add test case to verify the vault withstands the donation attack. ## Checklist Ensure you completed **all of the...

[WETH test] Add Reentrancy test

2

Possible attack vector: _burn is called after eth transfer in WETH withdraw(). In Erc20 _burn(), if the code "balance[from] -=amount" is unchecked or older solidity compiler version (0.6 or lesser)...

Fix typo in "SUB" hint

### 🐛 Describe the bug Test to activate test file | test name | test class -- | -- | -- test_linalg | test_addmv_cuda_float16 | (__main__.TestLinalgCUDA) test_linalg | test_inv_ex_singular_cuda_complex128 |...