Jagadish Krishnamoorthy
Jagadish Krishnamoorthy
any update ? I am facing the same issue.
@swtrse position of item inside array is not fixed. When item is deleted, the last element is swapped with item to be deleted index and the last element is removed/pop....
Main issue is when someone wants to removeStake(). Instead of swapping, we can just make the value as 0. Then we can maintain the index position, new users will be...
If there is interest, I can work on the PR to add the function and test cases.
@transmissions11 , transferFrom() is calling the helper function _isApprovedOrOwner() / reading storage _ownerOf[id] again; this added gas in some test cases. No need for new test cases since we can...
@transmissions11 ok to merge?
One of the goal of this library is to optimize for gas, calling _isApprovedOrOwner from transferFrom() increases gas which is not required. Not sure if we need to add test...
cc @jeffdaily @jithunnair-amd
The distributed test job on ROCm ran successfully. https://github.com/pytorch/pytorch/actions/runs/4002638127/jobs/6870189994 2023-01-25T04:12:06.4216319Z Attribute _set_backend not found 2023-01-25T04:12:06.4216839Z Attribute _set_backend not found The tests ran successfully after catching the exception.