Jae Bradley

Results 32 comments of Jae Bradley

@joeyism thanks for opening this PR - looks like there are some tests failing that are unrelated to your change. I'm looking into those test failures and I expect to...

I just merged #176 - feel free to rebase off of `v4` @joeyism and hopefully that resolves some of these test failures.

@KevinSetayesh this is a good idea! I think it's something that can be implemented - let me see how long it'll take. Note for myself - look for this `aria-label`...

@Vinnetou I have not implemented it yet, but getting your feedback on it's usefulness gives me even more incentive to implement it. Thanks for providing that feedback and hopefully I...

Actually, I misspoke - @KevinSetayesh I thought you were talking about a game's Box Score Page like https://www.basketball-reference.com/boxscores/201910220TOR.html (which is what my prior screenshot was referencing). But you'll notice that...

@jakeakopp thanks for opening this PR (and sorry for the massive delay in getting back to you). Just so I understand the intent - were you looking to add advanced...

@sebasdarius thanks for responding to my feedback! Feel free to tag me for re-review in a comment or by requesting review. I'm more than happy to add the playoff stats...

@TallData definitely a reasonable request - is it necessary that the different "option" types be reported as part of the salary information? ![image](https://user-images.githubusercontent.com/8136030/93890167-0964bb80-fcb8-11ea-8259-38c41c7d54f8.png)

Here's the list of all the teams: https://www.basketball-reference.com/teams/ Need to investigate if all the teams are supported or not.

I _think_ this should be resolved as of release [`4.13.1`](https://github.com/jaebradley/basketball_reference_web_scraper/releases/tag/4.13.1). If you're still seeing this issue, please re-open this issue and I can take a look. Apologies for the delayed...