basketball_reference_web_scraper icon indicating copy to clipboard operation
basketball_reference_web_scraper copied to clipboard

Add boolean didStart flag to player_box_score

Open KevinSetayesh opened this issue 4 years ago • 4 comments

Hey thanks for building this it's very useful. Would you be able to add a flag in the player_box_score output that describes whether the player started that game or not, thanks

KevinSetayesh avatar Oct 31 '19 04:10 KevinSetayesh

@KevinSetayesh this is a good idea!

I think it's something that can be implemented - let me see how long it'll take.

Note for myself - look for this aria-label when scraping?

image

jaebradley avatar Oct 31 '19 22:10 jaebradley

Hey @jaebradley, the original script is mega useful, thanks! I would love to add exactly what @KevinSetayesh is asking for, did you manage to implement it in the end?

Vinnetou avatar Dec 07 '19 10:12 Vinnetou

@Vinnetou I have not implemented it yet, but getting your feedback on it's usefulness gives me even more incentive to implement it.

Thanks for providing that feedback and hopefully I can deliver something sooner rather than later.

I appreciate your patience.

jaebradley avatar Jan 16 '20 22:01 jaebradley

Actually, I misspoke - @KevinSetayesh I thought you were talking about a game's Box Score Page like https://www.basketball-reference.com/boxscores/201910220TOR.html (which is what my prior screenshot was referencing).

But you'll notice that the Daily Leaders Page (like https://www.basketball-reference.com/friv/dailyleaders.fcgi?month=02&day=28&year=2020), which is what the player_box_score output fetches, has no field that indicates if a player started or not.

I'd prefer to not collect player box scores by iterating over every single game's Box Score Page for a given day vs. making a single request to the Daily Leaders Page.

So until Basketball Reference adds the concept of starting to the Daily Leaders Page, I won't deliver on this feature request - apologies for the confusion.

jaebradley avatar Feb 29 '20 22:02 jaebradley