Jacob Perron

Results 263 comments of Jacob Perron

Force setting parameters (or force re-declaring parameters) seem to defeat the purpose of read-only parameters. I think there's a confusion over the semantic meaning of "read-only". IIUC, the current meaning...

Seems like user error; calling shutdown before spin. What's an alternative, have spin return if the context is invalid?

Introducing a new common rclcpp exception to make things consistent sounds like an incremental improvement to me +1 As a drastically different alternative, we could remove the exception and have...

Although not required, it would be nice if the solution to this issue (or version of it) could be backported to Foxy.

As another pointer, there's [another implementation of this in `domain_bridge`](https://github.com/ros2/domain_bridge/blob/ce93807495a6f2f45e1a9ac8df657712f592cafc/src/domain_bridge/wait_for_graph_events.hpp#L208-L220) (inspired by the `rosbag2` logic). Here are other threads discussing this feature: - https://github.com/ros2/rosbag2/issues/601 - https://github.com/ros2/rmw/issues/304 I think it makes...

After some iteration, I've proposed adding new policy enum values at the RMW layer for selecting the 'best available' policy (ie. the policy that will match the most endpoints while...

I can also reproduce the issue with the latest Fast-DDS `2.1.x` branch (https://github.com/eProsima/Fast-DDS/tree/0670fb96255e6862c62f185c34cfd7551bd00b08). @MiguelCompany Can you think of a change between 2.1.x and v2.3.1 that might fix this?

Or I suppose it could be a change in `rmw_fastrtps_cpp` as well.

I don't think it's as simple as adding a new field to the message, there is also code in `rcl_action` and `rclpy` that works with GoalStatus. Before making further changes,...