Jacob Perron

While I think this is a good change to make, perhaps we consider making this a deprecation warning instead of a compiler error?This would avoid outright breaking downstream code. Thoughts?

I'm a bit confused. Currently, I do _not_ see a warning when trying to compile the following: ```c std::string log_message = "Created publisher"; RCLCPP_INFO(this->get_logger(), log_message.c_str()); ``` I'm pretty sure -Wall...

Also, what I am proposing is introducing a build-time warning (if feasible), not necessarily a runtime warning.

* Linux [](http://ci.ros2.org/job/ci_linux/16839/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/11417/) * Windows [](http://ci.ros2.org/job/ci_windows/17246/)

Rebased on `master`: * Linux [](http://ci.ros2.org/job/ci_linux/16840/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/11418/) * Windows [](https://ci.ros2.org/job/ci_windows/17272/)

It seems this change introduces a new warning on Windows: https://ci.ros2.org/job/ci_windows/17272/msbuild/

There's also a proposal to add common functionality to `rcl`: https://github.com/ros2/rcl/issues/898

> Is a generic subscriber available in Foxy? Not in rclcpp. Unless something like this PR can be done in an ABI compatible way, I don't think we can expect...

The cppcheck failures are happening on the master branch, so I guess it's not related: http://build.ros2.org/view/Fdev/job/Fdev__rclcpp__ubuntu_focal_amd64/25/testReport/

> @jacobperron who's the owner of that one? If you're referring to the rcl_interfaces PR, nobody yet; the core ROS 2 repositories have shared maintainership across the team. Typically, people...