Jacob Perron

Results 263 comments of Jacob Perron

Tagging issues related to `ExecuteProcess` in case we change the syntax in the future: https://github.com/ros2/launch/issues/394 and https://github.com/ros2/launch/issues/263

I'm experiencing this issue with gzserver, gzclient, and rqt. Here's a minimal reproducible example with Gazebo: ```py import sys import time import unittest import launch from launch.actions import IncludeLaunchDescription from...

I _think_ https://github.com/ros2/launch/pull/601 resolves this ticket. @fas2037 correct me if I'm wrong. edit: Or at least it should be possible to do what you want using `GroupAction` with the includes.

I can confirm the reported behavior for Rolling; the same applies to a regular Python launch file: ```py import launch from launch.actions import ExecuteProcess from launch.actions import IncludeLaunchDescription from launch.launch_description_sources...

So, the issue happens because `ThisLaunchFile` returns the value from the launch context's locals, https://github.com/ros2/launch/blob/074cd2903ddccd61bce8f40a0f58da0b7c200481/launch/launch/substitutions/this_launch_file.py#L59 and this value is overridden by `IncludeLaunchDescription` when it is executed, https://github.com/ros2/launch/blob/074cd2903ddccd61bce8f40a0f58da0b7c200481/launch/launch/actions/include_launch_description.py#L150-L152 Note, I think...

We could offer a single option to strip out color escape sequences for all logs (to file and screen), or offer separate options to configure the file and screen separately....

@bbworld1 I don't believe anyone is looking into this issue at the moment, so your contribution is welcome! Your proposal makes sense to me. Some other ideas building on top...

Tests added: - [ ] launch.LaunchInstrospector - [ ] launch.Substitution - [ ] launch.actions - [x] declare_launch_argument.py - [ ] emit_event.py - [ ] execute_process.py - [x] group_action.py - [x]...

Reading the [docs](https://docs.python.org/3.6/library/os.path.html), it sounds like if we use `os.path` it selects the module based on the platform: > `posixpath` for UNIX-style paths > `ntpath` for Windows paths > `macpath`...

The short answer is "no", the bridge does not currently support bridging actions. I haven't thought too much about how we would support Actions, but I imagine we could do...