Jack Yu

I think make lightning as a plugin of TiDB is a good idea. But if tikv-importer is also embedded, we may meet some CGO issues?

Sound great.

> > > > Upgrading tools provided by us (like tidb-operator or tiup) can set these two variables to 1 after upgrading is finished. > > I think it's better...

Insert statements with many placeholders will also consume too much memory! TiDB turns plan cache enabled by default in 6.1, many customers met this issue. I think we should limit...

> br and lightning didn't use grpc to connect TiDB, so I think the error log didn't came from br or lightning Yes, maybe tiflash, I think. I filed another...

This PR may also fix https://github.com/pingcap/tidb/issues/36536.

It is caused by https://github.com/pingcap/tidb/blob/f0717dfe07ae4842c7731b23368e664801d2bd42/sessionctx/variable/session.go#L251, it only collect row, so the unique index is missing to lock.

遇到了同样的问题在这里解决了，感谢。

> @jackysp did we have enough tests on adding this back to make sure it still works? @yudongusa When this switch was added originally, it seems that no testing was...

``` explain_test.go:314: Error Trace: executor/explain_test.go:314 executor/explain_test.go:390 Error: Not equal: expected: "4" actual : "0" Diff: --- Expected +++ Actual @@ -1 +1 @@ -4 +0 Test: TestCheckActRowsWithUnistore Messages: error comparing...