tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: bypass order by clause for fast point get plan (#50204)

Open ti-chi-bot opened this issue 1 year ago • 2 comments
trafficstars

This is an automated cherry-pick of #50204

What problem does this PR solve?

Issue Number: close #49920

Problem Summary:

What changed and how does it work?

It's better to resolve order by clause, but it will make some duplicated code.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Jan 12 '24 06:01 ti-chi-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 08:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:19:33.629699871 +0000 UTC m=+863662.377322982: :ballot_box_with_check: agreed by fixdb.
  • 2024-02-26 08:24:00.207468418 +0000 UTC m=+863928.955091529: :ballot_box_with_check: agreed by hawkingrei.

ti-chi-bot[bot] avatar Feb 26 '24 08:02 ti-chi-bot[bot]

    explain_test.go:314: 
        	Error Trace:	executor/explain_test.go:314
        	            				executor/explain_test.go:390
        	Error:      	Not equal: 
        	            	expected: "4"
        	            	actual  : "0"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-4
        	            	+0
        	Test:       	TestCheckActRowsWithUnistore
        	Messages:   	error comparing select * from t_unistore_act_rows

this test is not stable.

jackysp avatar Feb 26 '24 09:02 jackysp

/retest

jackysp avatar Feb 26 '24 09:02 jackysp

/retest

qw4990 avatar Feb 26 '24 10:02 qw4990

/test unit-test

qw4990 avatar Feb 26 '24 11:02 qw4990

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 26 '24 11:02 tiprow[bot]

/retest-required

jackysp avatar Feb 26 '24 12:02 jackysp

Something wrong with CI, it says TestPhysicalTableScanExtractCorrelatedCols failed, but it is not a test case included in release 7.1, I think.

jackysp avatar Feb 26 '24 13:02 jackysp

/retest

winoros avatar Feb 27 '24 08:02 winoros

/retest

winoros avatar Feb 27 '24 10:02 winoros

/merge

winoros avatar Feb 27 '24 12:02 winoros

@winoros: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Feb 27 '24 12:02 ti-chi-bot[bot]

/retest

winoros avatar Feb 27 '24 14:02 winoros

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.1@1b13108). Click here to learn what that means. The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50365   +/-   ##
================================================
  Coverage               ?   73.4148%           
================================================
  Files                  ?       1210           
  Lines                  ?     379313           
  Branches               ?          0           
================================================
  Hits                   ?     278472           
  Misses                 ?      83046           
  Partials               ?      17795           

codecov[bot] avatar Feb 28 '24 02:02 codecov[bot]