tidb
tidb copied to clipboard
*: bypass order by clause for fast point get plan (#50204)
This is an automated cherry-pick of #50204
What problem does this PR solve?
Issue Number: close #49920
Problem Summary:
What changed and how does it work?
It's better to resolve order by clause, but it will make some duplicated code.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fixdb, hawkingrei
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hawkingrei]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2024-02-26 08:19:33.629699871 +0000 UTC m=+863662.377322982: :ballot_box_with_check: agreed by fixdb.2024-02-26 08:24:00.207468418 +0000 UTC m=+863928.955091529: :ballot_box_with_check: agreed by hawkingrei.
explain_test.go:314:
Error Trace: executor/explain_test.go:314
executor/explain_test.go:390
Error: Not equal:
expected: "4"
actual : "0"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-4
+0
Test: TestCheckActRowsWithUnistore
Messages: error comparing select * from t_unistore_act_rows
this test is not stable.
/retest
/retest
/test unit-test
@qw4990: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Something wrong with CI, it says TestPhysicalTableScanExtractCorrelatedCols failed, but it is not a test case included in release 7.1, I think.
/retest
/retest
/merge
@winoros: We have migrated to builtin LGTM and approve plugins for reviewing.
Please use /approve when you want approve this pull request.
The changes announcement: LGTM plugin changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
/retest
Codecov Report
:exclamation: No coverage uploaded for pull request base (
release-7.1@1b13108). Click here to learn what that means. The diff coverage is100.0000%.
Additional details and impacted files
@@ Coverage Diff @@
## release-7.1 #50365 +/- ##
================================================
Coverage ? 73.4148%
================================================
Files ? 1210
Lines ? 379313
Branches ? 0
================================================
Hits ? 278472
Misses ? 83046
Partials ? 17795