tidb icon indicating copy to clipboard operation
tidb copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

*: reduce logs of too many pings

Open jackysp opened this issue 2 years ago • 3 comments

Signed-off-by: Jack Yu [email protected]

What problem does this PR solve?

Issue Number: close #36861

Problem Summary: https://github.com/pingcap/tidb/pull/17885 reduced parts of this kind of logs, it could still be found in v6.1.0. According to https://github.com/grpc/grpc/issues/28830, it seems it is not fixed yet. So disable the external pings for br and lightning.

What is changed and how it works?

Do not use PermitWithoutStream.

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

jackysp avatar Aug 03 '22 12:08 jackysp

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 03 '22 12:08 ti-chi-bot

LGTM, but PTAL @3pointer

bb7133 avatar Aug 04 '22 09:08 bb7133

br and lightning didn't use grpc to connect TiDB, so I think the error log didn't came from br or lightning

3pointer avatar Aug 09 '22 15:08 3pointer

br and lightning didn't use grpc to connect TiDB, so I think the error log didn't came from br or lightning

Yes, maybe tiflash, I think. I filed another PR to tiflash https://github.com/pingcap/tiflash/pull/5528. So another question, is PermitWithoutStream useful for br/lightning? @3pointer

jackysp avatar Aug 15 '22 04:08 jackysp