Giacomo Pozzoni

Results 131 comments of Giacomo Pozzoni

Simply put, this project is dead, it causes new cotire-specific issues when implementing PCH and requires to learn yet one more component in the complex task that setting up a...

At https://github.com/TrinityCore/TrinityCore we recently started using cotire and ran into this exact same issue. Could any cotire maintainer reply to this issue ? Just to get an idea if we...

I use `new PnP.Framework.AuthenticationManager(applicationId, certificate, tenant).GetContext(siteUrl)` which is the same as your 2nd try `PnP.Framework.AuthenticationManager.CreateWithCertificate()` . Which url do you pass to GetContext( ) ? is it the SPO site...

Just as a reminder, AzerothCore license AGPL is incompatible with TrinityCore GPL so we cannot accept any code copied from them (unless the original author decides to submit it, then...

> which weird, since they are based on a private trinity fork from sunwell and as far as I'm aware, there is only one person allowed to change the license...

@Ovahlord is this ready to be merged ?

@Ovahlord could you please fix the merge conflicts ?

@Keader @Ovahlord I hear you guys like the same spell used by auriyara, I set this PR back to draft until that's solved.

@Keader @Ovahlord is there anything left to do here ? just to merge it and fix whatever issue comes up in the days after ? will you have time to...

@leelf00 could you please do another test ingame with the latest changes ? after that we can merge this PR