Jack Bates

Apparently the `#gh-light-mode-only` and `#gh-dark-mode-only` fragments work on raw `` tags ... Does the following work, or do both images continue to appear? ```diff --- a/README.md +++ b/README.md @@ -1,7...

Thanks Kevin, that would be great

Thanks a lot for reviewing this Kevin. You understand correctly what's happening. However I think consumer.complete() must get invoked with only query data if the request is a GET, and...

Thanks a lot for following up Kevin > Just the fact that you ran into this situation means you already are mixing post and query data. I ran into this...

@wraithgar Thanks for the feedback! However when I went to write the test I realized this won't work, for two reasons: 1. I'd also need a `_cached` field on [`ETARGET`](https://github.com/npm/npm-pick-manifest#:~:text=the%20function%20will%20throw%20etarget%20if%20there%20was%20no%20matching%20manifest)...

@wraithgar Awesome thanks! +1 for removing it is a bugfix.

I added https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49667#event-4152249668 as a test. The usual timelines apply, so after re-requesting a review a PR will eventually become "Unreviewed" and end up in "Needs Maintainer Action" (it won't...

Thanks for thinking carefully about this. Yes (to point 4), if you reply to a changereq without pushing any changes you'd normally ping the reviewer and that would reset the...

Do you have to be a maintainer to reopen a PR once the bot closes it?

> Seems reasonable overall, but given that this also does some deeper changes, I'll wait until the new code gets merged (#234 and a following PR to change the stale...