Jack Bates
Jack Bates
> Can you add a test that adds (hopefully also removes) lines? It's fine to just make a copy of the test you added and hand-edit it. Done: 4183e39396f130778633aa68399fafca8a57ba46 I...
I added 49699 as a test (I had to edit it slightly because the CI isn't passing today). I ran `create-fixture 49699`, then changed the `checkSuite.conclusion` from "FAILURE" to "SUCCESS"....
`approverKind !== "maintainer"` would fix this? https://github.com/DefinitelyTyped/dt-mergebot/pull/254#discussion_r537579951
I see what you mean: I've now added docs covering what happens when the `repository` option does/doesn't have a branch, and what happens when the repo is automatically detected. In...
In the latest commit I split up the test into individual test cases.
[Statically linking libstdc++](https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html#index-static-libstdc_002b_002b) solved this for me. In my case: ``` > LDFLAGS=-static-libstdc++ yarn ``` Alternatively you could try dynamically linking against the same version of libstdc++ as is installed...
@RyanCavanaugh Would you try this PR? https://github.com/microsoft/TypeScript/pull/48228 I modified https://github.com/microsoft/TypeScript/pull/42316#discussion_r825141259 with the following overloads, to fix this issue and https://github.com/microsoft/TypeScript/issues/33700, without changing the current behavior of `any` and `unknown`: ```ts...
- [x] I've added Settings sections to each of the presets' readmes. Thanks for merging https://github.com/remarkjs/remark-lint/pull/284#issuecomment-1083381204! Ideally I'd like to land https://github.com/remarkjs/remark-lint/pull/286 and this one (https://github.com/remarkjs/remark-lint/pull/282#issuecomment-1061811554), then rebase https://github.com/remarkjs/remark-lint/pull/279#pullrequestreview-901858269?
- [x] Sorry, filled out now. :+1:
Does the difference matter? Outside of the implementation `true`, `'on'`, `'warn'`, and `1` don't feel different? Replacing `boolean|Label|Severity` with `Severity` simplifies the types/signatures a little bit. > What does it...