Jordan Aasen
Jordan Aasen
@Hinton @addisonbeck @shane-melton Just a quick reminder to get some 👀 on this PR. Thank you!! 🙏 🙏
@addisonbeck @shane-melton Any idea who from `bitwarden/team-secrets-manager-dev` may be able to review this? It's currently blocking this PR.
> Oooo very nice migration. I think we'll need to have the `ToastService` added to some other components that may be calling `super()`. @Jingo88 Great observation! I've updated the appropriate...
> Looks like there are a few areas that need the ToastService added as well for the failing Desktop and Browser builds. @Jingo88 Thanks for pointing this out. They've now...
@Jingo88 Are you able to approve on behalf of `bitwarden/team-auth-dev`?
> Changes to the Sproc look good! Just need to make a small change to the migration script. > > > Added Four targeted non‑clustered indexes. Eliminated scans on CollectionGroup,...
> Sproc change looks good to me. I'm less familiar with the impacts of the new indexes being created. > > @rkac-bw would you mind taking a look at the...
@rkac-bw @shane-melton Ready for another look!
@rkac-bw Thanks for the detailed and thoughtful feedback. Much appreciated! I believe I have fulfilled all your requests save for the `UPDATE STATISTICS` bit as I'm unsure as to how...
@rkac-bw Thanks for the detailed feedback. I appreciate it! I've applied your suggestions, should be ready for another look when you have time. ;)