[AC-2268] - migrate toast to CL service for admin-console
đī¸ Tracking
https://bitwarden.atlassian.net/browse/AC-2268
đ Objective
This PR migrates all use of platformUtilsService.showToast to the CL toastService in admin-console components
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â d694bd4d-f6ff-46ef-b73c-8cf05a989cc3
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 129 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 124 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 92 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 402 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 171 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 115 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 141 |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 122 |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 181 |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 104 |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 245 |
![]() |
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 196 |
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 |
Codecov Report
Attention: Patch coverage is 8.47458% with 108 lines in your changes missing coverage. Please review.
Project coverage is 32.85%. Comparing base (
bbe64f4) to head (8bb391e). Report is 102 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #10663 +/- ##
==========================================
- Coverage 32.88% 32.85% -0.04%
==========================================
Files 2665 2677 +12
Lines 81747 82206 +459
Branches 15433 15572 +139
==========================================
+ Hits 26881 27007 +126
- Misses 52778 53091 +313
- Partials 2088 2108 +20
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Hinton @addisonbeck @shane-melton Just a quick reminder to get some đ on this PR. Thank you!! đ đ
@addisonbeck @shane-melton Any idea who from bitwarden/team-secrets-manager-dev may be able to review this? It's currently blocking this PR.
