clients icon indicating copy to clipboard operation
clients copied to clipboard

[AC-2268] - migrate toast to CL service for admin-console

Open jaasen-livefront opened this issue 1 year ago â€ĸ 4 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/AC-2268

📔 Objective

This PR migrates all use of platformUtilsService.showToast to the CL toastService in admin-console components

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jaasen-livefront avatar Aug 21 '24 21:08 jaasen-livefront

Logo Checkmarx One – Scan Summary & Details – d694bd4d-f6ff-46ef-b73c-8cf05a989cc3

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 129 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 124 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 92 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 402 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 171 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 115 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 141
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 122
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 181
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 104
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 245
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 196
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 405

github-actions[bot] avatar Aug 21 '24 21:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 8.47458% with 108 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (bbe64f4) to head (8bb391e). Report is 102 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/member-dialog/member-dialog.component.ts 0.00% 10 Missing :warning:
.../app/admin-console/common/base.people.component.ts 0.00% 7 Missing :warning:
...ons/members/components/reset-password.component.ts 0.00% 7 Missing :warning:
...age/device-approvals/device-approvals.component.ts 0.00% 7 Missing :warning:
...dd-edit-dialog/domain-add-edit-dialog.component.ts 0.00% 7 Missing :warning:
...e/organizations/manage/group-add-edit.component.ts 0.00% 6 Missing :warning:
...main-verification/domain-verification.component.ts 0.00% 6 Missing :warning:
...onsole/providers/manage/user-add-edit.component.ts 0.00% 5 Missing :warning:
.../admin-console/components/collections.component.ts 0.00% 5 Missing :warning:
...le/organizations/policies/policy-edit.component.ts 0.00% 4 Missing :warning:
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10663      +/-   ##
==========================================
- Coverage   32.88%   32.85%   -0.04%     
==========================================
  Files        2665     2677      +12     
  Lines       81747    82206     +459     
  Branches    15433    15572     +139     
==========================================
+ Hits        26881    27007     +126     
- Misses      52778    53091     +313     
- Partials     2088     2108      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 21 '24 23:08 codecov[bot]

@Hinton @addisonbeck @shane-melton Just a quick reminder to get some 👀 on this PR. Thank you!! 🙏 🙏

jaasen-livefront avatar Aug 27 '24 17:08 jaasen-livefront

@addisonbeck @shane-melton Any idea who from bitwarden/team-secrets-manager-dev may be able to review this? It's currently blocking this PR.

jaasen-livefront avatar Aug 28 '24 21:08 jaasen-livefront