[PM-6565] migrate vault toasts to CL toastService

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-6565

📔 Objective

This PR migrates all Vault Toasts to CL Service

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 1.04167% with 95 lines in your changes missing coverage. Please review.

Project coverage is 34.40%. Comparing base (e815f89) to head (908576a). Report is 24 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ibs/angular/src/vault/components/view.component.ts	0.00%	11 Missing :warning:
...angular/src/vault/components/add-edit.component.ts	0.00%	10 Missing :warning:
...ular/src/vault/components/attachments.component.ts	0.00%	10 Missing :warning:
...s/collection-dialog/collection-dialog.component.ts	0.00%	7 Missing :warning:
...bulk-delete-dialog/bulk-delete-dialog.component.ts	0.00%	7 Missing :warning:
.../src/vault/components/folder-add-edit.component.ts	0.00%	6 Missing :warning:
...lt-filter/filters/organization-filter.component.ts	0.00%	3 Missing :warning:
...pps/desktop/src/vault/app/vault/vault.component.ts	0.00%	3 Missing :warning:
...ogs/bulk-move-dialog/bulk-move-dialog.component.ts	0.00%	3 Missing :warning:
...s/bulk-share-dialog/bulk-share-dialog.component.ts	0.00%	3 Missing :warning:
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10664      +/-   ##
==========================================
- Coverage   34.44%   34.40%   -0.05%     
==========================================
  Files        2974     2983       +9     
  Lines       90667    90785     +118     
  Branches    16989    17012      +23     
==========================================
+ Hits        31233    31234       +1     
- Misses      56968    57083     +115     
- Partials     2466     2468       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – a2194ca2-f499-4b9e-b842-7e69b8e04198

Great job, no security vulnerabilities found in this Pull Request

[Jingo88]

Oooo very nice migration. I think we'll need to have the ToastService added to some other components that may be calling super().

[jaasen-livefront]

Oooo very nice migration. I think we'll need to have the ToastService added to some other components that may be calling super().

@Jingo88 Great observation! I've updated the appropriate components. ;)

[eliykat]

Removing my review as I'm not a code owner and this seems pretty straightforward. Happy to let the code owners handle this unless there's something you'd like my input on specifically. Thanks!

[Jingo88]

Looks like there are a few areas that need the ToastService added as well for the failing Desktop and Browser builds.

[jaasen-livefront]

Looks like there are a few areas that need the ToastService added as well for the failing Desktop and Browser builds.

@Jingo88 Thanks for pointing this out. They've now been resolved. ;)

[jaasen-livefront]

@Jingo88 Are you able to approve on behalf of bitwarden/team-auth-dev?