Janine Liu
Janine Liu
Closing this due to inactivity. Please reopen if this is still an issue!
Turns out the actual culprit is an OS update -- the runner is now using `ubuntu-24` instead of `ubuntu-22`. I wonder if the narrowing conversion error is related to the...
Interesting... 🤔 @lilleyse could you see what `getSafeNumber` is returning when the test doesn't throw? (for `2^64 - 1`). In the past I've gotten weird errors with `uint64_t` that resulted...
I don't have GCC set up to try this locally, but these changes look good + make sense to me. Thanks @lilleyse !
Somewhat related to https://github.com/CesiumGS/cesium-unreal/issues/1300
Some forum thread roundup: - https://community.cesium.com/t/polygon-clipping-does-cut-geometry/41942 - https://community.cesium.com/t/unreal-engine-5-clipping-raster-polygon-and-gi-problems/32640 - https://community.cesium.com/t/cartographic-polygon-exclude-3d-tile-inside-not-working/16979 - https://community.cesium.com/t/geographic-polygon-collision-clipping-works-in-5-1-but-not-in-5-4/32661/6 - https://community.cesium.com/t/clipping-still-affects-gi-reflections/41953
This problem is coming up again for a different user's tileset as well: https://community.cesium.com/t/does-uploading-a-3d-tile-to-ion-change-the-mesh-at-all/39058/16
I'm going to close this for inactivity. It's pretty likely that there's something with the data itself, but no response on that thread unfortunately.
Thanks @GhisBntly for the detailed write-up! I can't say I have answers for everything at the moment, but I'll try to address some of these things... > Should we revert...
Sorry for the delayed response @GhisBntly! I see that you opened #1669 for this already, so I'll take a look in a bit :smile: > Let me rephrase: we don't...