injae kim

Results 62 comments of injae kim

https://github.com/spring-projects/spring-framework/commit/533149939371ee124ce02746cfade992d34a6e89 oh~ I understood your approach. if you need any help in the future, feel free to mention me ;)

`optionalQueryParam()` will be so useful to many users include me :)

Thank you! I'll investigate the cause of failed test and create fix PR soon :)

```java @Override @Test public void required_spec312_cancelMustMakeThePublisherToEventuallyStopSignaling() throws Throwable { // the publisher is able to signal more elements than the subscriber will be requesting in total final int publisherElements =...

> It's best identifying which operator delivers more than was demanded. Some race occurs which doesn't properly synchronise delivery with demand. I agree! good point. I think I found some...

@ikhoon really thank you for polishing PR & address comments 🙇 🙇 The code looks much simpler&nicer now!

FYI) target issue: https://github.com/spring-cloud/spring-cloud-netflix/issues/4257

Fix PR: https://github.com/bumptech/glide/pull/5447!