[Issue-4917] Add blockingTaskExecutor in Thrift services

[ChangguHan]

Motivation:

Add blockingTaskExecutor in Thrift services #4917

Modifications:

• Add useBlockingTaskExecutor into THttpServiceBuilder.java
• Apply useBlockingTaskExecutor into THttpService.java

Result:

• Closes #4917. (If this resolves the issue.)
• User can use useBlockingTaskExecutor from THttpServiceBuilder.java

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

🔍 Build Scan® (commit: 7876ae5459e6a633115982364d720e6b557f46e6)

Job name	Status	Build Scan®
build-windows-latest-jdk-21	✅	https://ge.armeria.dev/s/zyv5ychb74cyi
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/5gbtn7jfo3hbk
build-self-hosted-unsafe-jdk-21-snapshot-blockhound	✅	https://ge.armeria.dev/s/mkiwhxqqwo4bc
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/axbcmxzdpuqvy
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/yjdw3q4vjeymi
build-self-hosted-unsafe-jdk-17-leak	❌ (failure)	https://ge.armeria.dev/s/yq5kpsjeqryju
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/owj3lbzt64qjw
build-macos-12-jdk-21	✅	https://ge.armeria.dev/s/pjwk7fj7hxgpq

[minwoox]

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice: https://github.com/line/armeria/blob/10424c711cb22a2b001f9bd737453a25743dc18d/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java#L186

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

[ChangguHan]

@trustin I fix to decide whether to check useBlockingTaskExecutor in ThriftCallService instead of THttpService. Would you check this?

https://github.com/line/armeria/blob/096390525fcc3835a21004e466c39109e2f8b490/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java#L125-L139

[ChangguHan]

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice:

https://github.com/line/armeria/blob/10424c711cb22a2b001f9bd737453a25743dc18d/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java#L186

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

@minwoox Thank you for your review. I fix to check in ThriftCallService!

[trustin]

Revised and cleaned up the PR description and commit message.

[injae-kim]

Nice work @ChangguHan !!! 👍👍