spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Support Spring RestClient as TransportClientFactory

Open heowc opened this issue 9 months ago • 6 comments

Add related classes

  • RestClientDiscoveryClientOptionalArgs
  • RestClientEurekaHttpClient
  • RestClientTransportClientFactories
  • RestClientTransportClientFactory

Add property

  • eureka.client.restclient.enabled (default false)

Move commonly used classes

  • NotFoundHttpResponse
  • EurekaHttpClientUtils

Edit the document

Added similar tests referring to RestTemplate and WebClient

Close #4257

heowc avatar May 05 '24 07:05 heowc

Could you please inform me if there are any plans to phase out RestTemplate related implementations in the future? 🤔

heowc avatar May 05 '24 08:05 heowc

FYI) target issue: https://github.com/spring-cloud/spring-cloud-netflix/issues/4257

injae-kim avatar May 05 '24 10:05 injae-kim

gentle ping 😄

heowc avatar Jun 20 '24 04:06 heowc

Thanks @heowc, will take a look. We do not have a plan for phasing out RestTemplate at this point.

OlgaMaciaszek avatar Jun 26 '24 14:06 OlgaMaciaszek

Fixes gh-4257.

OlgaMaciaszek avatar Jul 04 '24 09:07 OlgaMaciaszek

Hi @heowc, I have pushed a fix in the same area: https://github.com/spring-cloud/spring-cloud-netflix/commit/b23c5873192aebaf147f0566ca4817e4ed475d24. Please merge the code and resolve any conflict before proceeding with working on this PR.

OlgaMaciaszek avatar Jul 08 '24 14:07 OlgaMaciaszek