injae kim
injae kim
I'll try this issue!
**2022-01-25** - Discuss some implementation issues on armeria slack([link](https://line-armeria.slack.com/archives/C1NGPBUH2/p1643038254042400))
FYI, We found some bug on `StreamMessageInputStream` so now fixing it on https://github.com/line/armeria/pull/4271. Please check https://github.com/line/armeria/issues/4268 for the details.
> I was meaning to add StreamMessageWriter.toOutputStream() rather than StreamMessage.toOutputStream() oh, I have to add `toOutputStream` on `StreamMessageWriter`! it's seems more easier. I'll update PR based on your comments! thanks...
Sorry for late 😢, I'll update this PR until `04/17`!
📌 Sorry for late, I'll update this PR until this `Thursday`
> Review comment: so I'd like to `change the design` of this API to safely write data to OutputStream.. Slack: https://line-armeria.slack.com/archives/CRQ5NNZQU/p1660663862501869 📌 (For history) I leave question on slack about...
> https://github.com/line/armeria/pull/4186#issuecomment-1211699740, So I'd like to change the design of this API .. > [Slack](https://line-armeria.slack.com/archives/CRQ5NNZQU/p1660663862501869), Let's close this PR and introduce `StreamMessage.fromOutputStream()` with another PR .. 📌 (For history) Due...
``` ByteStreamMessageOutputStreamTest > writeAfterAborted() FAILED java.lang.AssertionError: expectation failed (did not expect: onNext({1B, hex=0d})) ``` Hmm.. I'll fix writeAfterAborted() test until tomorrow~!
Hmm.. all tests success on my local 🤔