Silvan Mosberger

Results 311 comments of Silvan Mosberger

Just discovered that when using this with a GitHub App, it needs the "Repository/Administration/read-only" permission instead of the "Organization/Members/read-only" permission, see https://github.com/NixOS/org/pull/9. So I guess this is a breaking change....

I posted an answer in https://github.com/orgs/community/discussions/27114. For future reference if the links stop working again: You can get the workflow ID from the run ID ([reference](https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#get-a-workflow-run)): ```bash workflowId=$(gh api \...

I've just tried lorri with [my small Haskell project](https://github.com/infinisil/soph). It uses nixpkgs' `lib.sourceByRegex` to filter what gets included: ```nix { soph = (self.callCabal2nix "soph" (lib.sourceByRegex ./. [ "^\\src.*$" "^.*\\.cabal$" "^LICENSE$"...

Some more info: ``` $ nix-instantiate --eval --strict --read-write-mode -A src { _isLibCleanSourceWith = true; filter = ; origSrc = /home/infinisil/prj/soph; outPath = "/nix/store/9blqrn193vmlvzrv5y612rhkrmn77yrj-soph"; } $ tree -A /nix/store/9blqrn193vmlvzrv5y612rhkrmn77yrj-soph /nix/store/9blqrn193vmlvzrv5y612rhkrmn77yrj-soph...

@anka-213 Yeah I'm having that problem as well :(

@h7x4ABk3g With #152 you should now get an error if you try to use nodejs >= 15 Regarding this issue, would #151 help? You could manually adjust the packages sources...

In order to make this work, I'm thinking of these steps: 1. Introduce an easy way to patch arbitrary dependency sources, which to my knowledge can handle all use cases...

@cmoog My first PR #151 towards fixing this issue was merged somewhat recently. I might have some time soon to continue with the next step from https://github.com/nix-community/npmlock2nix/issues/153#issuecomment-1090533718. Would love some...

With NPM 7, hook scripts, which this PR relies on, are not supported anymore, see also https://github.com/nix-community/npmlock2nix/issues/110. However with #151 it will become possible to patch the sources of arbitrary...

You can replace https://github.com/tweag/npmlock2nix/blob/5fc6505adec1bafc3ae9ebd2a28673f6f5ed9a75/internal.nix#L27-L30 with `lib.strings.sanitizeDerivationName`, which then also takes care of ensuring it doesn't exceed the store path length: https://github.com/NixOS/nixpkgs/blob/36b02f89feb239d7c0e52c9f661beb8cf69d0ebd/lib/strings.nix#L746