npmlock2nix icon indicating copy to clipboard operation
npmlock2nix copied to clipboard

fix: patchShebangs in nonexecutable bin files (#106)

Open milahu opened this issue 4 years ago • 3 comments

close #106

milahu avatar Sep 14 '21 13:09 milahu

With NPM 7, hook scripts, which this PR relies on, are not supported anymore, see also https://github.com/nix-community/npmlock2nix/issues/110. However with #151 it will become possible to patch the sources of arbitrary packages, which should cover mostly the same use cases as hook scripts. @milahu Could you try out #151 and see if that can be used for your use cases?

infinisil avatar Mar 18 '22 20:03 infinisil

Could you try out #151 and see if that can be used for your use cases?

naah, thats too general my life is too short to add postPatch = "patchShebangs bin"; to every broken package

chmod +x and patchShebangs should run automatically on all the bin entries of a package

milahu avatar Mar 19 '22 09:03 milahu

With NPM 7, hook scripts, which this PR relies on, are not supported anymore

i guess you're confusing ...

milahu avatar Mar 19 '22 09:03 milahu