Xing Yang

Hi @cupnes , the 10/3 PRR deadline is for the PRR section to be filled out and ready to review. So you still have until 10/10, the KEP freeze deadline...

Thanks @salaxander! We'll be filing an exception soon. CC @Jiawei0227 @msau42

/milestone clear

/milestone v1.29

/ok-to-test

> @xing-yang is this good to get merged? @Madhu-1 Same as the other PR. We are going to cut a new release soon. I wonder if we still need to...

/ok-to-test

> @xing-yang is this good to get merged? @Madhu-1 We are going to cut a new release soon. I wonder if we still need to patch this in 7.0 branch.

We'll need to add metrics for snapshot-controller, similar to what we've added for volume snapshots. See example here: https://github.com/kubernetes-csi/external-snapshotter/blob/master/pkg/metrics/metrics_test.go#L256

This issue is about e2e tests. Here's an example: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/snapshottable.go We also need to add unit tests. I'll open another issue for that.