external-snapshotter
external-snapshotter copied to clipboard
kubernetes-csi
[release-7.0] use group secret for GetGroupSnapshotStatus
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change
/kind bug
/kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it:
GetGroupSnapshotStatus is a group operation on a specific group with an ID, we can use the group specific secret instead of List specific secret.
Signed-off-by: Madhu Rajanna [email protected] (cherry picked from commit b2447a0e5c7890c81a8fc5b1ac0961bf301d70cb)
backport of #1051 Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Cherry-pick from PR [#1051](https://github.com/kubernetes-csi/external-snapshotter/pull/1051) Use Group secret for the GetGroupSnapshotStatus RPC call
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Madhu-1 Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @Madhu-1. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@xing-yang is this good to get merged?
@Madhu-1 We are going to cut a new release soon. I wonder if we still need to patch this in 7.0 branch.