Xing Yang

Results 459 comments of Xing Yang

Instead of going from `one sidecar per repo` to `all sidecars in one repo`, should we also consider something in the middle where we combine some sidecars into one repo...

Have you observed this problem on both the controller and agent?

@NickrenREN I wonder if you've seen a similar issue in production.

@NickrenREN It affects the e2e tests. Details are in this issue: https://github.com/kubernetes/kubernetes/issues/102452 By disabling the external-health-monitor, the failure went away.

> Watch is persistent connection, and Node Watcher is a single instance controller. Is this really the root cause ? This needs more investigation. The observation is that the failure...

> This indicates the controller causes the failure (API throttling ?), but i still don't think Watch is the root cause. The external-health-monitor controller added more load to the API...