enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

PersistentVolume last phase transition time

Open RomanBednar opened this issue 2 years ago • 44 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): PersistentVolume release timestamp
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3762-persistent-volume-last-phase-transition-time/README.md
  • Discussion Link: https://docs.google.com/document/d/1-8KEG8AjAgKznS9NFm3qWqkGyCHmvU6HVl0sk5hwoAE/edit#bookmark=id.k72l93cygtip
  • Primary contact (assignee): @RomanBednar
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.28
    • Beta release target (x.y): 1.29
    • Stable release target (x.y): 1.31
  • [X] Alpha
    • [X] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3796
    • [X] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/116469
    • [X] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/42008
  • [x] Beta
    • [X] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4125
    • [X] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/120627
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/43532
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4644
    • [ ] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/124969
    • [ ] Docs (k/website) update(s)
      • https://github.com/kubernetes/website/pull/46463

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

RomanBednar avatar Jan 20 '23 08:01 RomanBednar

/sig storage

RomanBednar avatar Jan 20 '23 09:01 RomanBednar

/milestone v1.27 /kind feature /stage alpha

RomanBednar avatar Jan 20 '23 09:01 RomanBednar

@RomanBednar: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27 /kind feature /stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 20 '23 09:01 k8s-ci-robot

/milestone v1.27

jsafrane avatar Jan 30 '23 17:01 jsafrane

Hello @RomanBednar 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.27
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

If you could point me to the KEP (or KEP PR), a more detailed analysis can be made.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

fsmunoz avatar Feb 01 '23 12:02 fsmunoz

@RomanBednar if there's a PR for the KEP please tell me, I can have a look.

fsmunoz avatar Feb 08 '23 16:02 fsmunoz

@fsmunoz https://github.com/kubernetes/enhancements/pull/3796, merged with PRR approval for alpha

jsafrane avatar Feb 09 '23 11:02 jsafrane

@jsafrane thank you - could you please update the description field with the link to the KEP and the appropriate stage information?

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo. NOTE: there is a missing question in the Scalability section of the PRR, added recently. Since this is not mandatory for alpha I'm not taking that into consideration.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to alpha in v1.27

/label tracked/yes /remove-label tracked/no

fsmunoz avatar Feb 09 '23 21:02 fsmunoz

@fsmunoz: Those labels are not set on the issue: tracked/no

In response to this:

@jsafrane thank you - could you please update the description field with the link to the KEP and the appropriate stage information?

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo. NOTE: there is a missing question in the Scalability section of the PRR, added recently. Since this is not mandatory for alpha I'm not taking that into consideration.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to alpha in v1.27

/label tracked/yes /remove-label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 09 '23 21:02 k8s-ci-robot

Hi @RomanBednar 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

mickeyboxell avatar Mar 07 '23 15:03 mickeyboxell

Hi @RomanBednar 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the code PR is not linked in the issue description.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

fsmunoz avatar Mar 13 '23 10:03 fsmunoz

@fsmunoz thank you, although this will slip to next release as I did not have enough time to finish. Is there anything I need to do to flag this for next release? Apart from updating KEP and this issue?

RomanBednar avatar Mar 14 '23 08:03 RomanBednar

@RomanBednar when the new release starts this can be opted-in again. In the meantime I can mark it as Deferred for this release. Thanks!

fsmunoz avatar Mar 14 '23 15:03 fsmunoz

/milestone v1.28 /label lead-opted-in

jsafrane avatar May 16 '23 07:05 jsafrane

Hello @RomanBednar 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.28
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Update status to implementable in kep.yaml
  • Add Approver in the kep.yaml
  • Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

salehsedghpour avatar May 24 '23 03:05 salehsedghpour

@RomanBednar can you please mark the KEP as implementable?

jsafrane avatar May 31 '23 17:05 jsafrane

@RomanBednar can you please mark the KEP as implementable?

Already done in #4051

RomanBednar avatar Jun 02 '23 13:06 RomanBednar

Hello @salehsedghpour, with #4051 merged, The at risk label should be removed.

carlory avatar Jun 06 '23 02:06 carlory

Hey @wojtek-t by your comment here looks like you have already approved the PRR. Do you mind updating it's status on the enhancements board or should I go ahead and update it?

Atharva-Shinde avatar Jun 06 '23 15:06 Atharva-Shinde

I don't think that matters, but done :)

wojtek-t avatar Jun 06 '23 15:06 wojtek-t

Hello @RomanBednar ! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

taniaduggal avatar Jun 27 '23 11:06 taniaduggal

Hey @RomanBednar , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Rishit-dagli avatar Jul 12 '23 15:07 Rishit-dagli

@taniaduggal @Rishit-dagli Doc placeholder PR opened: https://github.com/kubernetes/website/pull/42008

RomanBednar avatar Jul 13 '23 08:07 RomanBednar

Hey again @RomanBednar :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:

  • [x] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • [ ] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too. For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :
    • https://github.com/kubernetes/kubernetes/pull/116469

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

salehsedghpour avatar Jul 17 '23 20:07 salehsedghpour

Hello @RomanBednar 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PR associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

Atharva-Shinde avatar Jul 19 '23 02:07 Atharva-Shinde

Hey again 👋 As the only related PR(according to the issue description) for the code freeze was merged by the additional time approved in the exception request, I am adding this back to v1.28 milestone and changing the status of this enhancement to Tracked :)

/milestone v1.28

Atharva-Shinde avatar Jul 24 '23 15:07 Atharva-Shinde

/remove-label lead-opted-in

npolshakova avatar Aug 27 '23 22:08 npolshakova

/milestone clear

xing-yang avatar Aug 31 '23 20:08 xing-yang

/milestone v1.29

xing-yang avatar Aug 31 '23 20:08 xing-yang

Hello @RomanBednar 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.29
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rayandas avatar Sep 26 '23 17:09 rayandas