Sean Allred

Results 314 comments of Sean Allred

Are you still getting this error? We certainly shouldn't be returning a value like `47` from `magithub-ci-status`. What does `(magithub-ci-status (magithub-ci-status--get-default-ref))` get you? ...does this possibly only happen during rebase?...

Yes, this shouldn't be happening and was an oversight.

Also need to make sure to update version numbers in README badges.

I will check my personal computer when I get home, but I had just installed delta to try this out, so I don't think I have any config unless installation...

`git config --list --show-origin | grep delta` yields nothing.

To be fair, I haven't used `delta` outside of `magit-delta` :-) but the diff-washing was visually working fine (at least, as I'd expect without prior experience with `delta`) from within...

Thanks for the feedback! (4) sounds like a bug. In this workflow, can you evaluate `(magit-get-upstream-branch (magit-get-current-branch))`? If it returns `"HEAD"`, that's why the default is what it is, though...

(9) would need some enhancements to `magithub-edit-mode` if we were to allow popups (which is a good idea and something magithub used to be able to do when it used...

But would you want that selection done in emacs or are you (and others in general) alright with running `git config --global` yourself? (By the way, [these are the options](https://github.com/vermiculus/magithub/blob/sa/confirm/magithub-settings.el#L169)...

(2) comes with gotchas for maintainers submitting pull requests for other repositories they have push access to. I'll see if I can make the default always be the remote associated...