Sean Allred
Sean Allred
I've realized while writing up a corresponding PR to rust-lang/git2-rs that inserting a value here could have a detrimental impact on compatibility with existing bindings. Does this need to wait...
Pinging on this. What's the next step here? Does this patch break ABI? Is there anything we can actually do about that?
Thanks for taking the time 😃 If there's no way to avoid breaking ABI, will it be just as much work for consumers if we change *all* the enum values...
Coming back around to this. What's the next step here? Expecting I'll need to rebase to resolve the new conflicts, that I don't expect those conflicts to be terribly difficult...
No worries! Conflicts are a sign of active development 😉 (edit: also, holy *cow* is https://github.com/libgit2/libgit2/pull/6133 exciting! Definitely agree dogfooding is going to be a boon here -- especially for...
Pinging on this again 😄
Thanks for testing and finding that issue, @bierbaum 😄 I'll happily rebase once your PR is merged. Otherwise I could rebase on it now and both can merge at the...
a5a6eeef86c490d73d5e82bba29fef7cd1eb5f2c includes some logging output for investigation. It appears the search space is null for these two calls: ``` log: new call to git_config_entries_get_unique log: needle: branch.local-track.remote log: haystack: log:...
I'm investigating `config::rename::can_rename` as a test that's failing -- I think all the other failures are coming from the `git_config_delete_entry` in `rename_config_entries_cb`. I think I've learned that at `git_config_delete_entry`, the...
I believe the above patch is in the right direction (based on ~three hours' learning about config backends...) though some tests are still failing. I believe this is because 'backends'...