Roch Devost

Results 303 comments of Roch Devost

@clementprevot Both `tracer.init()` and `tracer.use()` should be called before `jest-environment-jsdom` is imported, otherwise it's too late to disable the plugin.

@juan-fernandez This would still be worth fixing as we shouldn't cause an error even when the tracer is not initialized at the right time.

Had a discussion with our Java team and it looks like they do pattern matching to try to combine similar URLs into groups for HTTP clients. This is definitely something...

@hong823 There should be only a single `tracer.use()` with both option set in it. Multiple uses of `tracer.use()` are not supported right now so otherwise the second block wins. So...

@hong823 What version of the tracer are you using? We only added support for measuring HTTP spans with a custom service name recently, so it's possible that by changing the...

@hong823 This is supported out of the box and should be using the routes from the calls to `app.get('some-route', ...)`. Do you use a custom router or Express built-in one?

@YogeshTelawane Are you using the same version of everything in both environments? It's possible that some versions of Express (assuming you use Express) don't set `req.host`. In that case, you...

> You also drop support for a bunch of older versions of libraries we support. Is that because those versions don't run on Node.js 14 and higher? Yes, I had...

This is indeed very surprising, since we rely on a `async_hooks` to do the tracking which is built into Node, so I would expect this to track things properly. Before...

@krosen040 Were you able to try updating Node, and if yes, did it resolve the issue?