dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

drop support for node 12 and move `@types/node` to dev dependencies

Open rochdev opened this issue 3 years ago • 4 comments

What does this PR do?

Drop support for Node 12. I also moved @types/node to dev dependencies since the library is fairly large, and users of TypeScript should already have it loaded for the version of Node they are using while JavaScript users don't need it in the first place.

Motivation

Node 12 went EOL on 2022-04-30 and we only support maintained versions of Node in the latest release line. Node 12 will continue to be supported for a year in v2.x of dd-trace.

rochdev avatar Aug 05 '22 19:08 rochdev

Overall package size

Self size: 2.58 MB Deduped: 29.72 MB No deduping: 30.35 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.0.2 8.74 MB 14.46 MB
@datadog/native-metrics 1.4.2 6.61 MB 7.04 MB
@datadog/native-appsec 1.2.1 5.1 MB 5.43 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.0.0 105.44 kB 105.44 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
semver 5.7.1 61.58 kB 61.58 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.0 30.3 kB 34.77 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Aug 05 '22 19:08 github-actions[bot]

Codecov Report

Merging #2260 (42ad3e3) into master (42ad3e3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 42ad3e3 differs from pull request most recent head e1c378a. Consider uploading reports for the commit e1c378a to get more accurate results

@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files         220      220           
  Lines        8552     8552           
=======================================
  Hits         7950     7950           
  Misses        602      602           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 05 '22 20:08 codecov[bot]

You also drop support for a bunch of older versions of libraries we support. Is that because those versions don't run on Node.js 14 and higher?

bengl avatar Aug 05 '22 22:08 bengl

You also drop support for a bunch of older versions of libraries we support. Is that because those versions don't run on Node.js 14 and higher?

Yes, I had to find the minimum version that supports Node 14 for each of them.

rochdev avatar Aug 06 '22 00:08 rochdev