Roch Devost

Results 303 comments of Roch Devost

We're discussing how to better support this internally, but in the meantime unfortunately the only option is what was mentioned above. If you could share the type of source map...

We already catch errors from dd-trace and send them to the debug logs, so it should never happen that we throw. If it does happen then there is a bug....

For the first and the last one, they should be existing errors that dd-trace is only involved in because the scope manager is present in all asynchronous operations, and we...

@AaronMoat Looking at the code, the only way I can see for this to happen is that a request is started before the instrumentation is applied. This should not be...

@dyatko Why not go even lower? Since this is a fork of the original `memwatch`, it should support as low as `0.8.0`.

@dyatko Fair enough :) BTW I found this one that is already updated: https://www.npmjs.com/package/@airbnb/node-memwatch

Some context of why this would be useful: System tests always fail on forks. This means that we can never know if an external PR breaks something until it's merged....

@cbeauchesne The button exists, and it does appear in PRs, but clicking it only results in system tests running and always failing because it cannot access the API key.