Roch Devost

Results 303 comments of Roch Devost

Do the TypeScript decorators work according to the official [proposal](https://tc39.es/proposal-decorators/)? If that's the case, I think Babel would not be needed for the test.

Changing this to a feature request since the reason this doesn't work is that `fetch` is not supported yet so we don't have an integration for it.

All traces are sent to the agent even if they are marked to be dropped. It's the agent that takes the final decision to keep or drop a span, so...

Sorry for the slow response on this as I've been trying to figure out internally how we handle Kafka batches for other languages. The main issue with how the library...

@Cretezy Thanks for looking into this! The main difficulty with using these kinds of APIs is that they don't usually support integrating with existing traces. For example, how would a...

@tak1n The way the logging middleware works, it does look like it should work since it runs when the query happens. This is mostly problematic when the callback is run...

@tak1n What is the value of `tracer.scope().active()` in the query event handler? If it's the span from the middleware, then you could replace its resource name directly. If it's not...

@tak1n Did you check the value of `tracer.scope().active()` just to be sure? The way the above question was asked I'm not sure it was understood that you meant the asynchronous...

@tak1n I just tried it and it works for me. This is what I tried using the quick start code: ```ts // tracer.ts import { tracer } from 'dd-trace' tracer.init()...

@ThibaultGerrier It's possible that there is some kind of internal queueing happening, or that the way the event emitter is used it runs the listeners in the "wrong" context (right...