Rudi Grinberg

Hmm then I would suggest that we factor out the package somehow to reflect this. There should be a way to use this Expert module without downloading and installing conduit.

Should cookies also work directly with response/request? It will make it harder to make the mistake of using the wrong cookie module. For example using `Set_cookie_hdr` with `Request`

Some differences are indeed intentional, but others are just inconsistencies that you've correctly pointed out.

Sure. Just please don't make breaking changes. A few points: * Use the `[@@deprecated ..]` to deprecate functions * Prefer names without "filler" words such `with` * Reordering labelled/optional arguments...

In the new server implementation, you can initialize the server however you want pass the session to cohttp.

Lwt_bytes are fine, you're probably just encountering Bigarray related GC issues which are well documented. The issue is indeed with Lwt_io, but it's not related to Lwt_bytes. Lwt_io has this...

I'm not too familiar with how web servers are written in mirage these days, but I'd imagine that your entire web server can be represented as `(Request.t * Body.t) ->...

Yeah that's probably the least important change. Imo the naming of things is what's really ugly now. Unfortunately, cohttp has quite a few downstream users for a "beta" library. I...

Before talking about implementation details let me just state the goals I'm trying to achieve here: - I want users to be able to construct response bodies as conveniently as...

We could add a finalizer to the request handler that drains the body, but note that this still encourages poor behavior. You should start reading the body as soon as...