Rudi Grinberg

Results 729 comments of Rudi Grinberg

How about something like only enabling manual refreshes until this is done? The random pauses when opening a magit buffer are quite annoying.

Here's a complete trace from the profiler: ``` - command-execute 631 95% - call-interactively 631 95% - funcall-interactively 627 95% - magit-status 627 95% - magit-status-internal 627 95% - magit-mode-setup...

I don't have the trace, but I remember the trace but I remember where the slowness came from. The datetime parsing was actually quite slow: `parse-iso8601-time-string`

Feel free to add printers. Although note that the parsing of regular expressions does some simplifications (e.g. desugaring `+` into `*`), so whatever you print back isn't going to map...

@Drup would you like to merge this?

Thanks, that looks like a bug indeed. Would you mind sending a PR to do the validation? What about `Re.Posix`, does it suffer from the same problem?

No, but a `?max` parameter to the split functions would be a welcome addition.

Hmm, this seems like an oasis issue. We probably upgraded oasis between `1.5.0` and the current version.