ocaml-cohttp icon indicating copy to clipboard operation
ocaml-cohttp copied to clipboard

Cookies: work better with Header.t

Open avsm opened this issue 12 years ago • 4 comments

Right now the Cookie module works with string * string pairs, but it would be easier if it used the Header module directly (it was written before Header existed).

avsm avatar Dec 19 '12 13:12 avsm

Should cookies also work directly with response/request? It will make it harder to make the mistake of using the wrong cookie module. For example using Set_cookie_hdr with Request

rgrinberg avatar Dec 21 '13 20:12 rgrinberg

I'm inclined to leave this as-is for 1.0, or perhaps add a helper function to Header

avsm avatar Nov 09 '14 16:11 avsm

type cookie is still string * string, but we're in a glorious post-1.0 future for Cohttp, so I've reset the milestone to 2.0.

yomimono avatar Jan 05 '18 14:01 yomimono

Time sure does fly when you're having fun with http...

avsm avatar Jan 05 '18 14:01 avsm