Phil Quitslund
Phil Quitslund
> Did you have a chance to run it internally? Sorry, no. It may be a bit --- I'm still trying to land the last linter release in the SDK...
(And also for the nudge!)
@bwilkerson : FYI (not because I think you should fix this but because IIRC you added the initial smarts to respect `kDebugMode`).
/fyi @goderbauer
If I'm understanding, I think the issue is not that it's an _invalid_ regular expression but rather that it does not match what you think it should (e.g., in this...
> I interpreted it that it should warn about the missing r prefix. Oh! (It's early here; need more ☕️.) That's **_easier_** but likely to flag a bunch of false...
No worries @alescdb. This is a great conversation. Thanks for kicking it off! > Maybe a warning when using escaped characters without raw string should be enough ? Interesting idea....
Ah, OK. I honestly have to look up the grammar for regexps every time I use them for exactly the reason you describe. 🙄 Definitely annoying and if analysis can...
For the curious, Dart regular expressions have the same syntax and semantics as JavaScript regular expressions. Here's the relevant bit of grammar: http://ecma-international.org/ecma-262/5.1/#sec-15.10.1
With @scheglov's fix, I think we can close this?