Phil Quitslund comments

Results 286 comments of


                                            Phil Quitslund

improved docs for `sized_box_for_whitespace`

Thanks for the report @kuhnroyal. Do any of our current test cases produce lints for you? https://github.com/dart-lang/linter/blob/master/test_data/rules/sized_box_for_whitespace.dart

improved docs for `sized_box_for_whitespace`

@jacob314 is a good person for semantics.

improved docs for `sized_box_for_whitespace`

Thanks for the feedback! cc @jacob314 for his 2 cents.

improved docs for `sized_box_for_whitespace`

Cool. @kuhnroyal: feel free to take a crack at improvements? Maybe @a14n or @jacob314 could help?

proposal: `unnecessary_trailing_commas`

@goderbauer, @a14n: curious how compatible this advice is with current Flutter style guidelines?

unnecessary_overrides does not work for generic methods and null safety mix

Thanks! I've got this reproduced and see the problem. 👍

prefer_const_constructors_in_immutables: doesn't trigger if class has no constructor

💯 I think you're totally right. It'll be interesting to see if this catches any violations in flutter and internally...

Exclude {Key? key} from `always_put_required_named_parameters_first`

/fyi @goderbauer

proposal: `always_dispose_change_notifier`

/fyi @polina-c @goderbauer

Fix false negative in `prefer_is_empty`

Brian is right. This change has the potential to introduce a bunch of new diagnostics internally and so we need to proceed with caution. It's generally true of false negatives...