Phil Quitslund

Results 286 comments of Phil Quitslund

depend_on_referenced_packages requires analysis server restart to update

/fyi @jakemac53

Avoid `depend_on_referenced_packages` false positive in colocated test directory

fyi @jakemac53

The `prefer_interpolation_to_compose_strings` bad example isn't even valid.

This particularly bad example was fixed w/ #3294.

`noop_primitive_operations` enhancements

[`noop_primitive_operations`](https://dart-lang.github.io/linter/lints/noop_primitive_operations.html) might fit this bill already?

`noop_primitive_operations` enhancements

/fyi @a14n

[documentation] Provide a more complete example for use_build_context_synchronously

Thanks for opening this! @goderbauer: would you be a good person to give feedback on the proposed additions?

prefer_const_constructors false positive with for UI-as-code

Good catch!

prefer_const_constructors false positive with for UI-as-code

FWIW, an even smaller repro: ```dart class A { const A(this.p); factory A.f() => A([]); // prefer_const_constructors false positive here final List p; } ```

proposal: `avoid_renaming_method_parameters ` should allow _, __, ___ etc. for unused parameters

I'm inclined to agree with this change but since it's a recommended lint, I'd like to get a gut check from a few other folks. (Mainly to test the waters...

proposal: `avoid_renaming_method_parameters ` should allow _, __, ___ etc. for unused parameters

I think the rules value transcends `dart doc` (though the motivation does center it). That said, the current `dart doc` implementation does introduce a wrinkle... In its current incarnation, it...