Description

rework avoid_types_on_closure_parameters to allow not-redundant types

Fixes #3330 Fixes #2131 Fixes #1099

Coverage decreased (-0.1%) to 95.597% when pulling 0deed279950e467badffeed5227d9b9f8c417218 on a14n:rework_avoid_types_on_closure_parameters into 7d51bf6a88e40e8fb8011cda5f64bb75ea5fa397 on dart-lang:main.

Fantastic. We'll need to do an internal dry-run regardless , but if I understand the change correctly, this just addresses false-positives?

I understand the change correctly, this just addresses false-positives?

Yes it should relax the original version. So it shouldn't add new diagnostics.

Yes it should relax the original version. So it shouldn't add new diagnostics.

Add? If these are false positives, I'd expect there to be fewer...

Sorry if I'm being thick!

@pq that's what I tried to say : fewer lints

We'll need to do an internal dry-run

Did you have a chance to run it internally?

Did you have a chance to run it internally?

Sorry, no. It may be a bit --- I'm still trying to land the last linter release in the SDK (https://dart-review.googlesource.com/c/sdk/+/253501) and have a backlog of other tasks.

Will definitely queue this up for our next release though.

Thanks for your patience!

(And also for the nudge!)