Pavel Nikolov

Results 166 comments of Pavel Nikolov

@billiaz your commits need to be gpg signed

@GuyCarmy feel free to raise another PR. This seems like an insignificant change and if you can speed up the process I'd be happy to merge it.

@spacentropy are you planning to add the `if` statement that @naseemkullah has suggested above?

Do I need to bump chart version or update README.md?

I believe that we can pass extra command line args to the cleaner and indeed it would solve the issue.

https://github.com/graph-gophers/dataloader/pull/84

IMHO, this needs to be an option of the driver. The user can chose whether to print args or not...

I managed to get `sqlx` working with the `pq` driver and `instrumentedsql` using the following code: ``` sql.Register("instrumented-postgres", instrumentedsql.WrapDriver(&pq.Driver{}, instrumentedsql.WithTracer(opentracingsql.NewTracer()))) db, err := sql.Open("instrumented-postgres", config.DB.URL) ... dbx := sqlx.NewDb(db, "postgres")...

Thank you for your contribution. I really want custom directives to be supported in the library! There are few things to discuss, though. 1. Does your implementation support only directives...

@eko I really like the visitor pattern!