Pavel Nikolov

Results 166 comments of Pavel Nikolov

@kolanos Pull requests are welcome

Are you still looking into this issue? A set of failing unit tests would be a good start if you post such an issue.

Hi @gerarts This was just a reference implementation and it is not production ready. The graph-gophers/graphql-go library is protocol agnostic as it works with Golang channels. With that being said,...

Hi @shannontan-bolt I am willing to consider this if there is a benchmark that clearly demonstrates the benefits of this. I am happy to consider/merge any improvement to this library...

I am definitely going to consider breadth-first execution but I would like benchmarks that demonstrate a before/after comparison and clearly shows the benefit. Also, I expect that this wouldn't introduce...

Yes, indeed the fuzz testing is an amazing idea. Looking forward to Go 1.18. It would be ideal if we could generate more sophisticated queries based on a given schema.

The real value would come from fuzzing the `Exec` because this is where user input comes during request time.

I guess we'll have to wait for Go 1.18 to be released early in 2022 to merge this PR

A simple reproducible example would be appreciated.

If you treat the errors as any other data in your struct, then why does the library even need to know about this? It'll just be part of the response,...