Pavel Nikolov comments

Results 166 comments of


                                            Pavel Nikolov

Allow propagation of errors from Subscriptions channels into Request.Errs

You can always treat errors as data and add them to your schema. Otherwise, how do you imagine subscriptions? Sent from my phone > On 9 May 2019, at 11:22,...

Allow propagation of errors from Subscriptions channels into Request.Errs

I'm looking into the PR. I'm sorry I didn't understand the problem earlier.

Allow propagation of errors from Subscriptions channels into Request.Errs

There is a pending conflict and question... 👀

Allow propagation of errors from Subscriptions channels into Request.Errs

As a beginning, send the subscription error propagation first in a separate PR.

Fail to parse empty field lists for Object, Interface, and Input Object types

Thanks! I think this PR has to, actually, be split into 2 PRs. One for refactoring and another one to add validation for these types. This would make it much...

Fix bug: make Schema.Validate accept arguments

@romshark thank you for your contribution. I am happy with your PR and I'd be happy to merge it. However, there is one problem with it - it introduces a...

Fix bug: make Schema.Validate accept arguments

@romshark I'd be happy with that idea. And then have `Validate` call `ValidateWithArgs` passing `nil` for args.

ObjectType, Input, Enum, and Interface Definitions should not be allowed with zero fields.

@ssko1 feel free to take it and resolve the conflicts

Added possibility to propagate subscription error properly

I am not convinced that this should be part of the library. You can have your errors treated as data and have them in your schema resolver as fields. For...

Negative tax item - VAT included in the price

@jdutil yes, partially. I think now there is a pull request that has the issue fixed. Also you can take a look at quick and dirty solution I have in...