ordian

> After a burn-in I discovered that 12-secs reconnect hack can cause an issue if collator doesn't see activations for some reason. In case of a finality stall, relay chain...

Just to clarity: `connect_to_validators` doesn't issue a connection request per se. It adds validators to the reserved peerset. That means as long as we have them there and we're not...

After #5037, we can simplify https://github.com/paritytech/polkadot/blob/9907414f50f92c126f2f0a860d71332fc4d0f2d6/node/core/runtime-api/src/lib.rs#L450-L485 to always quiery v2 of session_info. When changing an existing method (e.g. v3 of SessionInfo), we can implement that backwards compatible functionality as a...

> what are we exactly testing here? This test spawn a network based on kusama of 80 honest validators and 20 malicious ones and 20 parachains. Malicious validators initiate disputes...

``` thread 'tests::should_parse_extrinsic_address' panicked at 'assertion failed: `(left == right)` left: `Ok(Bytes([18, 52]))`, right: `Err("Extrinsic index missing: example \"5:0\"")`', bin/node/inspect/src/lib.rs:299:9 ``` doesn't seem to be related to the PR EDIT:...

`impl-serde` 0.3.2 added support for deserializing without `0x` prefix: https://github.com/paritytech/parity-common/pull/598. This broke the test. Should I change the test? Or this assumption is baked in other places?

bot merge

cc @eskimor on dispute-distribution tests

In general, things like https://github.com/paritytech/polkadot/blob/d4d648e5781b6fefd83b3a22bf5a3914e460fc3f/node/network/dispute-distribution/src/tests/mod.rs#L421-L422 looks extremely flaky. Try running this test while compiling another copy of polkadot or other heavy load. Is it possible rewrite the tests not to...

> What logs should validators have enabled, is WARN/INFO enough to get useful info? `parachain::candidate-validation=debug` would be useful.