Nick Mancuso

Results 378 comments of Nick Mancuso

@CorvusYe extension of regexp for check properties is not minor, please create an issue for this so we can discuss.

@CorvusYe I am closing this PR since there has been no activity, note that this property is configurable by check property in configuration module, see https://github.com/checkstyle/checkstyle/issues/12141#issuecomment-1267837344 for more details. If...

It looks like `ignoreMethodNamesRegex` property can help you with suppression of most cases of these violations: ``` ➜ src cat config.xml ➜ src cat Builder.java public class Builder { private...

@strkkk Unless I am missing something, it does not support inspections config in project. So, until it does, it is not a real replacement, and has nowhere close to the...

>I recommend to not mess with hashcode/equals (human is always error prone on this contract) and make special method compareTo or somthing like this and use it instead. @romani As...

I think we should rethink on idea proposed in discord: treat all messages and details the same, i.e. replacement of problematic text by some obvious generic name. Example: `temp-var-123` becomes...

>we can have more cases. I think it is better to allow failure for new cases to make us aware of all possible variations and enumerate them in groovy file....

@stoyanK7 thanks for bringing this to my attention, inspections failure is not from your changes. I have changed some settings and restarted IDEA inspections. In the future, please put a...

> > rowInfluence > > After reading of doc "row" sounds weird. There are only lines in files. Does it make more sense to name it lineInfluence ? I think...

@Vyom-Yadav please see CI failures, and we can now do this PR in scope of #12100