Nick Mancuso

Results 378 comments of Nick Mancuso

@MUzairS15 please add test cases like those from https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8f2d5e2_2022050908/reports/diff/spoon/index.html (more complicated lambdas, multi line and multi statement). Please show that both acceptable levels of indentation are ok, and show violations...

@MUzairS15 please use a custom projects file with openjdk commented out or removed, there must be a large number of violations in this project.

@MUzairS15 report failure is from giganic number of violations being stored in memory from openjdk (70,000+ files with coding style that doesn't conform to the config you've provided). You can...

> I am not getting multiple acceptable levels If you build a checkstyle jar (`assemble` [phase](https://github.com/checkstyle/checkstyle/wiki/How-to-run-certain-phases-and-validations)), and run with same config locally, this should be consistent. > Can you please...

Please make sure that you are on the correct branch: ``` ➜ checkstyle git:(pull-11306) git rev-list HEAD | head -1 c3375f02f7abf7608fae8bf8865719407d638b54 ➜ checkstyle git:(pull-11306) mvn clean package -Passembly [INFO] Scanning...

@MUzairS15 remember that indentation check uses a hierarchical approach to determining correct indentation. Compare the two files; I can see that while your input has `class` as it's outer type,...

@MUzairS15 please do https://github.com/checkstyle/checkstyle/pull/11306#pullrequestreview-887312458

Please do not use tabs in input file, I suspect this is the problem. You can use regexp to replace all `\t` with ` ` (four spaces).

Once we approve this issue, we should close https://github.com/checkstyle/checkstyle/issues/7797 and any child/ associated issues.