Nick Mancuso

Results 378 comments of Nick Mancuso

> I am ok to make max limit as 120 lines... I agree that this is a good limit under normal circumstances. Limiting file lengths will help to make violations...

@Abhishek-kumar09 is this related to https://github.com/checkstyle/checkstyle/issues/9341 ?

> Is there any update on when this will be fixed? PRs are welcome, anyone can reuse work from https://github.com/checkstyle/checkstyle/pull/9766, we were close to merging this one.

@IzumiKanata we will be closing PR if there is no activity, please let us know if you would like to continue or not.

> We can probably merge this PR but keep issue open. I would rather not, there is conflicts now and CI is failing, plus we have added to test input...

@rnveach see https://github.com/checkstyle/checkstyle/pull/11805#issue-1291342040, I have created a new projects file at https://github.com/checkstyle/contribution/pull/613

> push code to CI. if we enforce EN locale for all, it will resolve all problems for all users, and we need to figureout only how override that in...

@as23415672 it appears that report generation is failing because you do not have a fork of checkstyle: https://github.com/checkstyle/checkstyle/actions/runs/2511432701

@as23415672 do you plan to continue work on this PR?