Nick Mancuso

Results 378 comments of Nick Mancuso

We have lost contact with author, anyone is welcome to reuse code here to solve issue.

@stoyanK7 please create entirely new test input instead of extending existing tests. Also, please update documentation with new tokens and example of new behavior.

@stoyanK7 address other CI failures first (NPEs in both openjdk and checkstyle), these might help you to refine code a bit.

>All the mutations in https://github.com/checkstyle/checkstyle/commit/3ef61de60c1ae93cf0d9a06c56ad84cfedeefa88#diff-4e0a49a8be36cb3b594f01212755dcf16d2f4fc701ded58ee7404f7180ed958fR148 have been addressed, mutator has also been added to each profile (PRs open). Please show proof via CLI output on latest master (use `git log...

> According to the current logic (logic in the master branch) no violation is given in both the cases, should this behavior be changed? No, this is complicated/ nuanced check,...

@Vyom-Yadav can we mark this as ready for review?

> I can add documentation, but what are our thoughts regarding it? I do not know yet, hopefully experience from https://github.com/rnveach/checkstyle-extras will tell :) > I recommend to merge, let...

@guillerodriguez thanks for your bug report, please follow the template and add a link to the affected check.

@Vyom-Yadav I have updated branch filters, let’s try again.