Jan Kotas

Looking at the test failures - the reflected type needs to be also included in Equals method.

@buyaa-n I have pushed a commit with a bunch of perf tweaks and simplifications. The commit description has the details. Let me know if it looks good to you or...

Looks good to me, modulo the last two comments

String substring does not feel like the right place to do this optimization. Have you looked ať the top callers that create these strings? Would it make more sense to...

I am not sure. Substrings of this shape are likely going to be produced by allocation heavy parsers, they are unlikely to survive gen0 gc, and so getting rid of...

msbuild has custom string deduplication engine that is able to take spans (that covers substrings) and string builders (that covers concatenated strings), without material if the string. Check description of...

Likely fixed as part of https://github.com/dotnet/runtime/issues/73405#issuecomment-1206151902

> > Does this PR also cover crossgen2? > Yes works for R2R. And, probably, for NativeAOT NativeAOT compiler and crossgen use exact same infrastructure. If it works for one,...

> I fully agree, should I still keep NgenDisasm for backward compatibility? There is no backward compatibility to be worried about. We should delete all configs that start with `NGen`...

> 0.1% TP I assume that this is measured with optimizations on. What is the TP regression for minopts?