Jan Kotas

Results 402 comments of Jan Kotas
trafficstars

https://github.com/dotnet/runtime/issues/2209: Unable to pull image mcr.microsoft.com/...

A lot of PRs are failing with: `Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly...

It is not convenient to keep updating this issue with all intermittent test failures hit by the CI. I have started marking issues that are intermittently causing CI failures with...

FWIW, I find the permanently pinned issues distracting. I am actively forcing myself to avoid clicking on the "x" button because it would unpin the issue for everybody. I have...

I am wondering who is the target audience for the pinned issues. The pinned issues communicate the following currently: - We have 12 overarching themes that we are working on...

Frozen segments allocated at runtime, like that ones added by Egor for string literals, should count towards GC hard limit. They are no different from other memory managed by the...

UpdateFrozenSegment would need some work to implement the backout correctly. Its call site assumes that it will never fail. Also, the extra memory was committed already when `UpdateFrozenSegment` is called,...

From outside the runtime point of view, the string literals are managed heap memory just like any other. I expect that the diagnostic tools will be treating them as such....

> While the discussion is still in flux, can we merge this change for now? Sounds good to me.

Intersection is good enough. I do not think they need to be exactly consistent. There are good reasons for runtime-specific public surface, one example are runtime-specific hosting APIs.